Design change related to issue #100 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejv
requested changes
May 24, 2023
| status_list = { | ||
| 'status': tsc['status'], | ||
| 'count': str(tsc['count']), # needs to be a string to render | ||
| 'color': tsc['color'] |
There was a problem hiding this comment.
Suggested change
| 'color': tsc['color'] | |
| 'color': tsc['color'], | |
| 'label': tsc['label'] |
Add status label (aka display)
| <td class="d-flex"> | ||
| {% for status in tsc.status_list %} | ||
| <a href="{% url 'plugins:netbox_inventory:asset_list' %}?inventoryitem_type_id={{ tsc.inventoryitem_type }}&status={{ status.status }}" class="w-100 me-2"> | ||
| {% badge value=status.status|capfirst|add:' - '|add:status.count bg_color=status.color|add:' w-100' %} |
There was a problem hiding this comment.
Suggested change
| {% badge value=status.status|capfirst|add:' - '|add:status.count bg_color=status.color|add:' w-100' %} | |
| {% badge value=status.label|add:' - '|add:status.count bg_color=status.color|add:' w-100' %} |
I suggest using status label here.
At least we use localized custom status values, so displaying them consistently throughout UI is desirable.
|
Thank you for the review, label does make more sense there. I also added overflow, for people who might have many badges, so it doesn't break their UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the way data is being passed to the template for a cleaner and easier way to loop over that data.
Let me know if something needs to be refactored in
inventoryitem_group.pyfile. Python is not my go-to language 😄