Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specialsource-maven-plugin also renames echopet methods if methods collide #116

Closed
Arnuh opened this issue Dec 4, 2021 · 1 comment
Closed
Labels

Comments

@Arnuh
Copy link
Owner

Arnuh commented Dec 4, 2021

Example is EntityAgeablePet#setBaby(boolean) which overrides a method in Mob resulting in it getting renamed to obf name and baby petdata toggling failing

Only solutions I can think of are to rename such methods or request/add a way to filter methods to https://github.com/md-5/SpecialSource/

@Arnuh Arnuh added the Bug label Dec 4, 2021
@Arnuh Arnuh mentioned this issue Dec 4, 2021
Arnuh added a commit that referenced this issue Dec 5, 2021
With the future goal of no pet extending EntityPet and only implementing the interface, this requires more handling to be moved to what is called "PetBase".

Doing this move also solves setBaby getting remapped due to developing on mojang mapped NMS.
@Arnuh
Copy link
Owner Author

Arnuh commented Feb 1, 2022

As mentioned in d169736, with #106 slowly making pets the 'real' entity we will be moving away from "IEntityXXPet" and instead handling any setting of variables for a pet via "EntityXXPetBase". This will allow the PetBase class to properly get its method calls remapped to the obfuscated naming without renaming our setters.

@Arnuh Arnuh closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant