Plan hop(x, x) to tumble(x) (#809)

ArroyoSystems · Dec 12, 2024 · a8b95f1 · a8b95f1
1 parent 0828ff7
commit a8b95f1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/crates/arroyo-planner/src/lib.rs b/crates/arroyo-planner/src/lib.rs
@@ -588,7 +588,12 @@ fn find_window(expression: &Expr) -> Result<Option<WindowType>> {
                         slide
                     );
                 }
-                Ok(Some(WindowType::Sliding { width, slide }))
+                if slide == width {
+                    // a hop window with slide == width is a tumble window
+                    Ok(Some(WindowType::Tumbling { width }))
+                } else {
+                    Ok(Some(WindowType::Sliding { width, slide }))
+                }
             }
             "tumble" => {
                 if args.len() != 1 {

diff --git a/crates/arroyo-planner/src/test/queries/hop_to_tumble.sql b/crates/arroyo-planner/src/test/queries/hop_to_tumble.sql
@@ -0,0 +1,7 @@
+create table impulse with (
+     connector = 'impulse',
+     event_rate = '10'
+);
+
+select count(*) from impulse
+group by hop(interval '10 seconds', interval '10 seconds');