Add prometheus and pushgateway into the docker image to get metrics working #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonrnewhouse
approved these changes
Apr 4, 2023
| @@ -4,6 +4,7 @@ ENV DEBIAN_FRONTEND=noninteractive | |||
| WORKDIR /opt/arroyo/src | |||
| ARG MOLD_ARCH | |||
| ARG PROTO_ARCH | |||
| ARG PROM_ARCH | |||
There was a problem hiding this comment.
Might be worth finding some way to have one architecture arg that we convert to the various names.
There was a problem hiding this comment.
Agreed, should be possible with a small bash script?
jacksonrnewhouse
pushed a commit
that referenced
this pull request
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.