Use REST API for metrics #229
Conversation
jbeisen
force-pushed
the
metrics-rest
branch
2 times, most recently
from
aef92cb to
e7b2048
Compare
jbeisen
force-pushed
the
metrics-rest
branch
2 times, most recently
from
546198d to
77022cd
Compare
| /// Get a job's metrics | ||
| #[utoipa::path( | ||
| get, | ||
| path = "/v1/pipelines/{pipeline_id}/jobs/{job_id}/operator_metric_groups", |
There was a problem hiding this comment.
operator_metric_groups is a bit long, maybe just operator_metrics?
There was a problem hiding this comment.
Sure, I guess, but to follow the REST convention of plural nouns implying being collections then we'll need to name this struct/object like this:
pub struct OperatorMetric {
pub operator_id: String,
pub metric_groups: Vec<MetricGroup>,
}
...which is weird because it's not a single metric. This kind of naming problem is kind of a consequence of too many levels of nesting in api objects.
There was a problem hiding this comment.
I'll try to come up with something better though.
There was a problem hiding this comment.
I actually think this is the best option even though it's long. Let me know if you have any other ideas.
arroyo-api/src/rest_types.rs
Outdated
| #[serde(rename_all = "camelCase")] | ||
| pub struct Metric { | ||
| pub time: u64, | ||
| pub value: u64, |
There was a problem hiding this comment.
in this protobuf this is a double, should this be f64?
jbeisen
force-pushed
the
metrics-rest
branch
3 times, most recently
from
09f9404 to
444fbf4
Compare
Add an endpoint to the REST API to retrieve metrics. Use the new endpoint in the console.
Add an endpoint to the REST API to retrieve metrics. Use the new
endpoint in the console.