Windowless Joins #61
Merged
Windowless Joins #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this addresses #65 as well. |
mwylde
approved these changes
Apr 19, 2023
| let mut key = record.key.clone().unwrap(); | ||
| let value = record.value.clone(); | ||
| let records = { | ||
| let right_rows = right_state.get_all_values_with_timestamps(&mut key).await; |
There was a problem hiding this comment.
get_all_values_with_timestamps materializes the data into a vec, which is somewhat wasteful since all we're going to do is iterate over it. Instead it could return an iterator to avoid that extra allocation.
| records.push(Record { | ||
| timestamp: record.timestamp.max(timestamp), | ||
| key: Some(key.clone()), | ||
| value: (value.clone(), right_value.clone()), |
There was a problem hiding this comment.
do we need to clone right_value?
There was a problem hiding this comment.
Yeah, it's a pointer at this point.
| } | ||
| }; | ||
|
|
||
| let mut left_state: KeyTimeMultiMap<K, T1, _> = ctx.state.get_key_time_multi_map('l').await; |
There was a problem hiding this comment.
Is there any way to share this logic between left/right?
sql: detect when a join without a preceding window is happening, plan to JoinWithExpiration worker: introduce JoinWithExpiration, add some out of order to Nexmark. control plane: Have the NodeScheduler tolerate a node restart. frontend: Fix impulse source creation to properly create timed sources. compiler: standardize Duration quoting, fix Impulse code generation, add JoinWithExpiration
jacksonrnewhouse
force-pushed
the
event_joins
branch
from
87a0484 to
b35f029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we handle joins whose inputs don't contain a preceding window operator. Now each record is joined against all of the existing records on the other side, emitting pairs. This only supports inner joins. I've also made several changes/improvements, including
duration_to_syn_expr().