setting imagePullSecrets for workers #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
requested changes
Jun 11, 2024
|
Updates pushed up. Resolved all the changes. |
mwylde
requested changes
Jun 12, 2024
There was a problem hiding this comment.
This still isn't quite working. It might be useful to try testing it locally with docker desktop. With a local k8s environment, you can test it by creating a values.yaml file like this:
artifactUrl: "/tmp/arroyo-test"
checkpointUrl: "/tmp/arroyo-test"
volumes:
- name: checkpoints
hostPath:
path: /tmp/arroyo-test
type: DirectoryOrCreate
volumeMounts:
- name: checkpoints
mountPath: /tmp/arroyo-test
Then building an image from your branch and deploying it locally:
$ docker build . -f docker/Dockerfile -t ghcr.io/arroyosystems/arroyo:tip --target arroyo
$ helm install arroyo k8s/arroyo -f values.yaml
k8s/arroyo/templates/configmap.yaml
Outdated
| command: ["/app/arroyo-bin --config-dir /config worker"] |
There was a problem hiding this comment.
This still isn't quite right. With this, trying to run this in helm gives the error
Configuration is invalid!
• invalid type: found sequence, expected a string for key "default.kubernetes-scheduler.worker.command" in /root/.config/arroyo/config.yaml YAML file
It should be restored to what it currently is in master.
| @@ -59,6 +59,10 @@ data: | |||
| {{- end }} | |||
| image: "{{ .Values.worker.image.repository }}:{{ .Values.worker.image.tag }}" | |||
| image-pull-policy: "{{ .Values.worker.image.pullPolicy }}" | |||
| image-pull-secrets: | |||
| {{- with .Values.imagePullSecrets }} | |||
There was a problem hiding this comment.
image_pull_secrets is defined as a string, but here it's passed in an object which fails:
Configuration is invalid!
• invalid type: found unit, expected a string for key "default.kubernetes-scheduler.worker.image-pull-secrets" in /root/.config/arroyo/config.yaml YAML file
crates/arroyo-rpc/default.toml
Outdated
| @@ -64,6 +64,7 @@ resource-mode = "per-slot" | |||
| name-prefix = "arroyo" | |||
| image = "ghcr.io/arroyosystems/arroyo:latest" | |||
| image-pull-policy = "IfNotPresent" | |||
| image-pull-secrets = "IfNotPresent" | |||
There was a problem hiding this comment.
Is this a sensible default for this?
mwylde
force-pushed
the
set-imagepullsecrets-worker
branch
from
6f33f34 to
e3c8c38
Compare
mwylde
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the imagepullsecrets. Not sure this is the best location to do this in.