Show SQL names instead of primitive types in catalog #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
commented
Apr 27, 2023
jbeisen
commented
Apr 27, 2023
jacksonrnewhouse
approved these changes
Apr 27, 2023
mwylde
approved these changes
Apr 27, 2023
mwylde
reviewed
Apr 27, 2023
arroyo-api/src/sources.rs
Outdated
| @@ -329,7 +344,7 @@ impl TryFrom<SchemaField> for SourceField { | |||
| type Error = String; | |||
|
|
|||
| fn try_from(value: SchemaField) -> Result<Self, Self::Error> { | |||
| let typ = match value.typ { | |||
| let typ = match value.clone().typ { | |||
There was a problem hiding this comment.
The clone is not necessary, just need to take a reference to value.typ instead of taking it by value
Suggested change
| let typ = match value.clone().typ { | |
| let typ = match &value.typ { |
There was a problem hiding this comment.
If I do that then we get this error:
error[E0277]: the trait bound `SourceField: From<&SchemaField>` is not satisfied
--> arroyo-api/src/sources.rs:365:43
|
365 | .filter_map(|f| f.try_into().ok())
| ^^^^^^^^ the trait `From<&SchemaField>` is not implemented for `SourceField`
|
= note: required for `&SchemaField` to implement `Into<SourceField>`
= note: required for `SourceField` to implement `TryFrom<&SchemaField>`
= note: required for `&SchemaField` to implement `TryInto<SourceField>`
Should I implement those functions?
There was a problem hiding this comment.
You would still need to clone that (as you try_into() is implemented on the owned type) but it's preferable to cloning the entire struct. It's not a huge deal here (as this isn't performance-sensitive code), and eager cloning can make rust development easier.
mwylde
approved these changes
May 8, 2023
Define a mapping of primitive types to SQL types. Add a field 'sql_name' to the SourceFieldType message, and populate it for primitive types. Display this value in the catalog. Resolves: #73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a mapping of primitive types to SQL types. Add a field 'sql_name' to the SourceFieldType message, and populate it for primitive types. Display this value in the catalog.
Resolves: #73