Rds configurationoptions support #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>
|
Example usage: |
|
Looks good to me. I will however merge into a branch first to let it run the functional tests. |
ArsenyYankovsky
changed the base branch from
master
to
rds-configurationoptions-support
ArsenyYankovsky
merged commit 56da11e
into
ArsenyYankovsky:rds-configurationoptions-support
ArsenyYankovsky
added a commit
that referenced
this pull request
Mar 23, 2020
* Rds configurationoptions support (#31) * build(deps): bump acorn from 5.7.3 to 5.7.4 Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com> * Support for passing AWS.ConfigurationOptions towards data-api-client Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Service Config options fix * Fix passing options Co-authored-by: cklam2 <cklam2@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@cklam2 The changes are released with version 1.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request that solves #8:
Support for argument 'serviceConfigOptions' (AWS.ConfigurationOptions)
The change also requires an update in TypeORM. That part is already implemented but no pull request made yet. Needs to wait till this changed is merged into typeorm-aurora-data-api-driver.
Once merged I'll create a pull request in TypeORM for the changes in this branch.