Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor minters with MinterBase parent class #463

Merged
merged 15 commits into from
Jan 30, 2023
Merged

Refactor minters with MinterBase parent class #463

merged 15 commits into from
Jan 30, 2023

Conversation

ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Jan 25, 2023 •
edited
Loading

Description of the change

Refactor minters to remove redundant internal function code to the MinterBase parent class.

Follow-on activity from #449.

@ryley-o ryley-o requested a review from a team as a code owner January 25, 2023 22:01
@ryley-o ryley-o self-assigned this Jan 25, 2023
@ryley-o ryley-o requested a review from jakerockland January 25, 2023 22:01
@ryley-o
Copy link
Contributor Author

ryley-o commented Jan 30, 2023

@jakerockland - this is ready for a re-review now that it has been refactored to use a MinterBase class🙏

@ryley-o ryley-o requested a review from jakerockland January 30, 2023 18:00
@ryley-o
Copy link
Contributor Author

ryley-o commented Jan 30, 2023

@jakerockland - wanted to note that I eliminated the UpdatedIsEngine event during construction and from the interface. After integrating these minters into our indexing, that event seemed unnecessary and unhelpful, and removing it simplifies the interface model in this PR quite a bit.

jakerockland
jakerockland approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a couple nit suggestions–happy to discuss more as needed, otherwise LGTM! :)

contracts/interfaces/0.8.x/IFilteredMinterV3_Mixin.sol Outdated Show resolved Hide resolved
contracts/minter-suite/Minters/MinterBase_v0_1_1.sol Show resolved Hide resolved
contracts/minter-suite/Minters/MinterBase_v0_1_1.sol Show resolved Hide resolved
contracts/minter-suite/Minters/MinterBase_v0_1_1.sol Outdated Show resolved Hide resolved
contracts/minter-suite/Minters/MinterBase_v0_1_1.sol Outdated Show resolved Hide resolved
contracts/minter-suite/Minters/MinterBase_v0_1_1.sol Outdated Show resolved Hide resolved
@ryley-o ryley-o enabled auto-merge January 30, 2023 20:03
jakerockland
jakerockland approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jakerockland jakerockland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes ser – LGTM.

@ryley-o ryley-o mentioned this pull request Jan 30, 2023
Merged
@ryley-o ryley-o merged commit 9d7afd3 into main Jan 30, 2023
@ryley-o ryley-o deleted the refactor-minters-with-MinterUtils branch January 30, 2023 22:14
@ryley-o ryley-o changed the title Refactor minters with MinterUtils library Refactor minters with MinterBase parent class Feb 4, 2023
@ryley-o ryley-o mentioned this pull request Feb 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakerockland jakerockland jakerockland approved these changes

Assignees

@ryley-o ryley-o

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryley-o @jakerockland