re-organize engine deployment details #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerockland
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Store Art Blocks Engine deployment details/logs in a root
/deployments/directory instead of inside the/scripts/directory.This organization more clearly divides the responsibility of deployment scripts and deployment logs. In a follow-on PR, the V3_Engine deployment script will be updated to be able to handle
input.jsonfiles (also stored in the/deployments/directory, which will fully decouple specific engine deployment details from any specific contract or deployment script files. This will enable removing the requirement to copy and paste solidity code or typescript code when performing an Engine deployment.