Minor Max Invocation Patch #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerockland
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Patches our minters with local max invocations to handle an edge case that should never be encountered on mainnet.
Specifically, the minters now revert a purchase when invocations on a project are >= max invocations on the minter.
Tests were updated and drove the development in this PR.
Also note that for convenience and consistency, a similar design choice as #478 was implemented. When a price/auction is configured, if a project's minter-local max invocations have never been populated, they are automatically synced to the values on the core contract. This removes an extra call that should be performed by most artists to ensure gas efficiency, but is often missed.