Serial English Auction (nouns-style) minter #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jakerockland - this is ready for review. Would appreciate thorough feedback before writing all of the tests 🙏 Also note that our internal design document has been created and is ready for review 👍 |
ryley-o
added
do not merge
…clearer error messaging)
SEA minter - hold n+1 token to improve UX
|
Folded in PR #546 to this PR 🙏 |
add ejectNextTokenTo admin-only function to SEA
jakerockland
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
So exciting – excellent work here @ryley-o!
Handful of minor nits, but generally LGTM! 🙌 🔥
jakerockland
approved these changes
Mar 21, 2023
|
|
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add a serial English auction (nouns-style) minter.
Fixes #185
Overview
This minter provides an option to mint and distribute a project's tokens one at a time via consecutive, on-chain English auctions.
Tests
nonReentrantmodifiers. This was because the two untestednonReentrantmodifiers are only providing dual redundancy, and are not our primary layer of defense.