Code

SEA minter code review actions#659

Code

Merged

jakerockland merged 14 commits intomainArtBlocks/artblocks-contracts:mainfrom sea-code-review-actionsArtBlocks/artblocks-contracts:sea-code-review-actionsCopy head branch name to clipboardApr 25, 2023

+206-187

Commits

Commits on Apr 24, 2023

• 3. refactor only admin/only artist logic

  ryley-o

  committed
  9bb25ca

  Copy full SHA for 9bb25ca

• 4. _onlyNonZero

  ryley-o

  committed
  0d07f3d

  Copy full SHA for 0d07f3d

• 8. updateAllowableAuctionDurationSeconds

  ryley-o

  committed
  a5c5ea9

  Copy full SHA for a5c5ea9

• 9. updateMinterMinBidIncrementPercentage

  ryley-o

  committed
  2a4644d

  Copy full SHA for 2a4644d

• 10. updateMinterTimeBufferSeconds

  ryley-o

  committed
  143e401

  Copy full SHA for 143e401

• 12. togglePurchaseToDisabled

  ryley-o

  committed
  0bfd0a4

  Copy full SHA for 0bfd0a4

• 13. configureFutureAuctions, 15. ejectNextTokenTo, 33. _projectIsConfigured (use auction duration instead of base price for configuration state)

  ryley-o

  committed
  d581afd

  Copy full SHA for d581afd

• 17. settleAuctionAndCreateBid

  ryley-o

  committed
  0986ad7

  Copy full SHA for 0986ad7

Commits on Apr 25, 2023

• 18. settleAuction, 27 projectActiveAuctionDetails, 28 getTokenToBid, + remove auction.initialized, use auction.currentBidder instead

  ryley-o

  committed
  15a0453

  Copy full SHA for 15a0453

• update tests for auction to no longer include initialized param

  ryley-o

  committed
  4698371

  Copy full SHA for 4698371

• 20. createBid_l34

  ryley-o

  committed
  b3cf13b

  Copy full SHA for b3cf13b

• 28. projectConfigurationDetails

  ryley-o

  committed
  dcc3449

  Copy full SHA for dcc3449

• General Notes 1 - named arguments

  ryley-o

  committed
  9b23c9b

  Copy full SHA for 9b23c9b

• add documentation about front running risks associated with bidding

  ryley-o

  committed
  5997cce

  Copy full SHA for 5997cce