Remove the usage of SELFDESTRUCT in BytecodeStorage
#668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very much agreed – super important not to deploy any contracts using this modified structure until #660 is resolved (will have an initial draft PR up for that shortly here, after which we can look at these two changesets in tandem). |
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
jakerockland
changed the title
SELFDESTRUCT in BytecodeStorageSELFDESTRUCT in BytecodeStorage
yoshiwarab
approved these changes
May 2, 2023
* Support basic semantic versioning – and ensure interop with backwards compatible reads (tests added) * update the version string * minor adjustment and a song: https://www.youtube.com/watch\?v\=vOreqez4v9Y * Update to reflect better v1/v0/unknown versioning semantics * Update documentation and code structuring * Refactor size == 0 check * clean up offset checks * `STORE2`-compatible reads in `BytecodeStorage` (#681) * Update BytecodeStorage library to provide backwards-compatible reads that are compatible with SSTORE2 as the fallback read option, in advance of plans to split off reads into a shared external public utility library, in-companion to the embedded internal library for writes. * Whoops, forgot to add all the files yo * add support for manual-offset reads * SSTORE2 / explicit bytes reads restructure * Comment fix * Filename fix * Filename fix * Better typing for tests * spelling fixes * Split `BytecodeStorage` into public/internal libraries (#684) * basic MVP of split library (with tests) * Adjusted tests for split library setup * minor modifier adjustment * Adjust optimizer runs * optimizer order * nit * get interface from deployed contract * get interface from deployed contract * ensure libraries are linked * library linkkinnnn * More linking fixes in tests * update Engine Flex as PoC (#688) * fix the rest of the test bindingsgit diff * OPTIMIZOOOOOR * remove unnecessary using for * Fixed comment * public constants * Update library naming convention * DEPLOYOOOOOR * DEPLOYOOOOOR * format * Address nits --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com> --------- Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Purge the use of purging!
Closes #451
Only merge after #665 – also, do not merge until review feels coherent between this and the TBD PR that addresses #660Do not merge until this changeset looks good in addition to #670, as both should be merged at the same time.
Note that the approach of maintaining multiple versioned files of our library is taken in order to allow for testing backwards compatible reads, though backwards compatible reads cannot be reliably added until addressing #660 which is being taken on in a companion PR to this one. These PRs should be reviewed in tandem.