remove temporary minterfilter indexing patch #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoshiwarab @lyaunzbe - gentle ping on this one 🙏 |
lyaunzbe
approved these changes
Feb 13, 2023
yoshiwarab
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Removes the temporary patch instilled in #187, and only indexes MinterFilters if they are already in the store.
Follow-on to ArtBlocks/artblocks-contracts#482
The bugged cases where MinterFilters were deployed, in the subgraph config, but were not in the store have been handled operationally, and a new MinterFilter
Deployed()event is now handled to ensure all deployed MinterFilterV1's are saved to the subgraph store immediately upon deployment.There is no major urgency to deploy a subgraph with this update, as there are no Engine contracts that are not planned to be indexed in the immediate future.