Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to remove AtIndex from dependency registry gets #238

Closed
wants to merge 4 commits into from
Closed

Update to remove AtIndex from dependency registry gets #238

wants to merge 4 commits into from

Conversation

jakerockland
Copy link
Contributor

Description of the change

Minor adjustment to be consistent with consistency adjustments made in: ArtBlocks/artblocks-contracts#895

@jakerockland jakerockland marked this pull request as ready for review July 27, 2023 15:24
@jakerockland jakerockland requested review from a team, ryley-o and yoshiwarab July 27, 2023 15:24
@jakerockland
Copy link
Contributor Author

@ryley-o @yoshiwarab am I right in my understanding that I need to cut a new version of the contracts ABI package before the ABI generation here will work as intended (and unblock the breaking tests)?

@ryley-o
Copy link
Contributor

ryley-o commented Jul 27, 2023 •
edited
Loading

am I right in my understanding that I need to cut a new version of the contracts ABI package before the ABI generation here will work as intended (and unblock the breaking tests)?

@jakerockland yes, but in until you cut a new release, you can actually copy a more up to date DependencyRegistryV0.json file into abis-supplemental/, and it will overwrite the file from contracts ABI package 👍 see more details in abis-supplemental/readme.md.

@jakerockland
Copy link
Contributor Author

cc @sterlingcrispin for vis on how these contracts + subgraph PRs inter-relate

@ryley-o
Copy link
Contributor

ryley-o commented Sep 6, 2023

We already ended up implementing this in the minter suite V2 branch, which was merged to main today. It was required when we updated to use the new contracts package 👍

@ryley-o ryley-o closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryley-o ryley-o Awaiting requested review from ryley-o

@yoshiwarab yoshiwarab Awaiting requested review from yoshiwarab

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakerockland @ryley-o