Skip to content
This repository has been archived by the owner on Nov 22, 2020. It is now read-only.

Incorrect title #185

Merged
merged 3 commits into from
Nov 22, 2017
Merged

Incorrect title #185

merged 3 commits into from
Nov 22, 2017

Conversation

wbison
Copy link
Contributor

@wbison wbison commented Nov 21, 2017

Only first word should be cap'ed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Only first word cap'ed

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Incorrect title
@wbison
Copy link
Contributor Author

wbison commented Nov 21, 2017

First pull request (and what a monumental one) - sorry if I messed up.

@ArtSabintsev
Copy link
Owner

no problem! Fix the tests, too! :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Only first word cap'ed
@wbison
Copy link
Contributor Author

wbison commented Nov 21, 2017

hmm - the new commit was automagically added to the existing pr? I have to study this PR stuff.

Have I just started my career as Open Source Developer?

@ArtSabintsev
Copy link
Owner

Yes you have! Thanks for your contribution!

@ArtSabintsev ArtSabintsev merged commit b08738a into ArtSabintsev:master Nov 22, 2017
@ArtSabintsev
Copy link
Owner

Added this fix to the Swift version as well: https://github.com/ArtSabintsev/Siren/releases/tag/3.1.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants