Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 251 rd data 1d ahead #253

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Fix 251 rd data 1d ahead #253

merged 5 commits into from
Jan 13, 2025

Conversation

dbrakenhoff
Copy link
Collaborator

See #251 and commit message

@dbrakenhoff
fix #251:
a4ab28e 
- adjust add_day values for daily rainfall files
- modify default add_day value in interpret_knmi_file
- add tests for checking raw and interpreted data vs stored files.
- add data files
@dbrakenhoff
up version for new releaes
41746a8
This was linked to issues Jan 10, 2025
RD data one day ahead of KNMI #251
Closed
Add tests that check specific values for KNMI downloads #252
Closed
@dbrakenhoff dbrakenhoff added the bug Something isn't working label Jan 10, 2025
@dbrakenhoff dbrakenhoff self-assigned this Jan 10, 2025
@dbrakenhoff dbrakenhoff mentioned this pull request Jan 10, 2025
Merged
rubencalje
rubencalje approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only checked the code visually (and did not run anything). I think these changes should fix the problem with the extra day.

Good that we test this now as well.

@dbrakenhoff dbrakenhoff merged commit e276256 into dev Jan 13, 2025
6 checks passed
@dbrakenhoff dbrakenhoff deleted the fix_251_rd_data_1d_ahead branch January 13, 2025 08:57
@dbrakenhoff dbrakenhoff mentioned this pull request Jan 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubencalje rubencalje rubencalje approved these changes

Assignees

@dbrakenhoff dbrakenhoff

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests that check specific values for KNMI downloads RD data one day ahead of KNMI
2 participants
@dbrakenhoff @rubencalje