Bug: Deleted Insulin Entries reappear when new bolus is added immediately after deletion

[dnzxy]

Description:

• Deleted Insulin Entries reappear when new bolus is added immediately after deletion
• Found this bug on latest dev (commit: db39664).

How to reproduce:

• Have multiple insulin treatment entries in history (in the following recording I created them, because I had none in my simulator)
• Remove entries
• Immediately after removing, move to enter a new manual bolus
• The previously deleted entries reappear in History

Side note: I tried to reproduce this multiple times, on one occasion Xcode crashed upon opening history after adding the manual bolus after deleting entries.

Side note 2: This only regards manual boluses and SMBs, not external insulin boluses, as these do not make their way through DeviceDataManager's pumpManager. After deleting multiple entries and then adding in a new manual bolus within the same cycle (not a fresh cycle), this is what the debug log shows. The 3 collapsed events are boluses that were deleted, the uncollapsed one contains the new manual bolus.

Recording:
https://github.com/Artificial-Pancreas/iAPS/assets/48965855/fccd7474-a311-45fa-97e1-0e8c40c3ead5

Edit: This bug seems to stem from Loop. I was able to reproduce this in a Loop simulator.