Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile failing to disable “Change CR” when CR toggle off #890

Closed
macconnellk opened this issue Sep 28, 2024 · 9 comments
Closed

Profile failing to disable “Change CR” when CR toggle off #890

macconnellk opened this issue Sep 28, 2024 · 9 comments
Labels
Already Implemented in Dev

Comments

@macconnellk
Copy link

macconnellk commented Sep 28, 2024 •
edited
Loading

When creating a profile that adjusts basal and ISF, but not CR, I am toggling the following in Profile screen:
-More Options: On (reveal more toggles)
-Change ISF and CR: Off (reveal ISF and CR toggles)
-ISF: On
-CR: Off

I expect CR to remain unchanged. However, despite toggling CR off the CR is still adjusted indicated in Enacted pop-up.

Example: When setting the profile slider to 105%, and toggling the above profile settings, CR is being adjusted 5% from 16.6 to 15.8
@Jon-b-m
Copy link
Member

Jon-b-m commented Sep 30, 2024

When creating a profile that adjusts basal and ISF, but not CR, I am toggling the following in Profile screen: -More Options: On (reveal more toggles) -Change ISF and CR: Off (reveal ISF and CR toggles) -ISF: On -CR: Off

I expect CR to remain unchanged. However, despite toggling CR off the CR is still adjusted indicated in Enacted pop-up.

Example: When setting the profile slider to 105%, and toggling the above profile settings, CR is being adjusted 5% from 16.6 to 15.8

Hi! I just tested again. It works for me. Are you using latest main or dev iAPS version?

@Jon-b-m
Copy link
Member

Jon-b-m commented Sep 30, 2024

Are you perhaps also using dynamic CR, as this will also change your CR?

@Jon-b-m
Copy link
Member

Jon-b-m commented Sep 30, 2024

Can I see your pop-up and your CR settings, please?

@macconnellk
Copy link
Author

I am on Main 5.0.2. Dynamic CR is not enabled.

It looks like it is only happening for a saved Profile. When I run it directly from the Profiles screen and hit start it's fine. When I save it as a preset I get the issue. Screenshots attached.

image

image

image

image

@macconnellk
Copy link
Author

macconnellk commented Oct 1, 2024 •
edited
Loading

First popup is with the saved profile 105% Basal/ISF enabled. The Saved Presets Screenshot above indicates in the 105% preset that only ISF is toggled. But the CR is being changed.

2nd pop up is when the same toggles (ISF on, CR off) are run directly without using a saved preset. It runs as expected.

Actually looks like it's reversing the two when run as a saved profile.

@macconnellk
Copy link
Author

macconnellk commented Oct 1, 2024 •
edited
Loading

The middleware error is because I deleted everything from middleware including the blank function. Wanted to ensure no middleware was at fault.

@Jon-b-m
Copy link
Member

Jon-b-m commented Oct 1, 2024 •
edited
Loading

Thanks, this additional info is very helpful. I can replicate the issue now.

@Jon-b-m
Copy link
Member

Jon-b-m commented Oct 1, 2024

Will push a fix tonight

Jon-b-m added a commit that referenced this issue Oct 2, 2024
@Jon-b-m
Refactor
fd6a5b8 
Resolve issue 890: #890
Add some more logging of overrides.

Add additional check for missing TIR data to prevent any eventual out of bounds errors.
@Jon-b-m Jon-b-m mentioned this issue Oct 2, 2024
Merged
@Jon-b-m
Copy link
Member

Jon-b-m commented Oct 2, 2024

@macconnellk I've now made a PR to dev branch resolving this issue: #892

@Jon-b-m Jon-b-m mentioned this issue Oct 2, 2024
Merged
Jon-b-m added a commit that referenced this issue Oct 2, 2024
@Jon-b-m
Refactor (#892)
bd68137 
Resolve issue 890: #890
Add some more logging of overrides.
Resolve nasty typo preventing some ISF overrides.
Add additional check for missing TIR data to prevent any eventual out of bounds errors.
Jon-b-m added a commit that referenced this issue Oct 4, 2024
@Jon-b-m
Merge dev updates into 5.2.2
2d92ed4 
Resolve issue 890: #890
Add some more logging of overrides.
Resolve a nasty typo preventing some ISF overrides.
Add additional check for missing TIR data to prevent any eventual out of bounds errors.
German Crowdin updates
@Jon-b-m Jon-b-m mentioned this issue Oct 4, 2024
Merged
Jon-b-m added a commit that referenced this issue Oct 4, 2024
@Jon-b-m
5.2.2
468348c 
Resolve issue 890: #890
Add some more logging of overrides.
Resolve a nasty typo preventing some ISF overrides.
Add additional check for missing TIR data to prevent any eventual out of bounds errors.
German Crowdin updates
@Jon-b-m Jon-b-m mentioned this issue Oct 4, 2024
Merged
Jon-b-m added a commit that referenced this issue Oct 4, 2024
@Jon-b-m
Release 5.2.2 (#894)
07ce9f0 
Resolve issue 890: #890
Resolve a nasty typo preventing some ISF overrides.
Add additional check for missing TIR data to prevent any eventual out of bounds errors.
Add some more logging of overrides.
German Crowdin updates
@Jon-b-m Jon-b-m closed this as completed Oct 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in iAPS Development Board Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Already Implemented in Dev
Projects
No open projects
iAPS Development Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jon-b-m @macconnellk