Change permissions required for calendar in iOS 17+ #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnzxy
reviewed
Oct 6, 2023
dnzxy
reviewed
Oct 6, 2023
dnzxy
reviewed
Oct 6, 2023
dnzxy
reviewed
Oct 6, 2023
mountrcg
pushed a commit
to mountrcg/iAPS
that referenced
this pull request
Oct 6, 2023
…eas#234) * Change permissions required for calendar in iOS 17+
mountrcg
pushed a commit
to mountrcg/iAPS
that referenced
this pull request
Oct 7, 2023
…eas#234) * Change permissions required for calendar in iOS 17+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue caused by iOS 17+ requiring higher permissions for the calendar integration in iAPS.
Enabling calendar when no permissions have been granted or rejected:
Enabling calendar when existing permissions are not enough:
Untested on xcode 14, but it's a port of these PRs from XDrip4iOS:
JohanDegraeve/xdripswift#461
JohanDegraeve/xdripswift#470
There might also be issues with permissions in Info.plist, but I don't quite understand how to change that information in xcode. I would appreciate someone more knowledgeable had a look at that particular part.