Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Temp Target Slider Numbering Positioning #321

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Change Temp Target Slider Numbering Positioning #321

merged 2 commits into from
Nov 10, 2023

Conversation

dnzxy
Copy link
Contributor

@dnzxy dnzxy commented Nov 10, 2023

This PR changes the slider number positioning for the Temp Target editor to be consistent with the changed positioning of the profile override percentage slider introduced with PR #316. It thereby adheres to feature request as of #291.

Side notes:

  • A little more spacing was also added to give the thumb/finger a bit more screen space to control the slider
  • The empty section heading (Section(header: Text(""))) was removed to get consistent Section spacing.
Before After *NEW*
image image
image image

@Jon-b-m Jon-b-m merged commit 62c2aff into Artificial-Pancreas:dev Nov 10, 2023
@dnzxy dnzxy deleted the temp-target-slider branch November 10, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnzxy @Jon-b-m