Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventual BG with 1 decimal #9

Closed
wants to merge 1 commit into from

Conversation

bjornoleh
Copy link
Contributor

The eventual BG value is a highly uncertain estimate, hence it makes little sense to present this number with two decimal places.

"numberFormatter" was replaced with a new "eventualBGFormatter", since the former is used in many places, and I did not want to check the implications of changing this formatter for all.

Added eventualBGFormatter
@Jon-b-m
Copy link
Member

Jon-b-m commented Mar 29, 2023

It will be considered. We're planning a big UX/UI makeover, but will not disclose or release until complete.

@Jon-b-m Jon-b-m closed this Mar 29, 2023
@bjornoleh bjornoleh deleted the eventual_BG branch November 22, 2023 21:31
Jon-b-m pushed a commit that referenced this pull request Dec 30, 2023
 (#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
mountrcg referenced this pull request in mountrcg/iAPS Dec 30, 2023
… OmniKit PR #9 & Artificial-Pancreas#18 and MinimedKit PR #6 (Artificial-Pancreas#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
mountrcg referenced this pull request in mountrcg/iAPS Dec 30, 2023
… OmniKit PR #9 & Artificial-Pancreas#18 and MinimedKit PR #6 (Artificial-Pancreas#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
dnzxy pushed a commit to dnzxy/iAPS that referenced this pull request Dec 31, 2023
… OmniKit PR Artificial-Pancreas#9 & Artificial-Pancreas#18 and MinimedKit PR Artificial-Pancreas#6 (Artificial-Pancreas#438)

+ Extend low reservoir notification range
+ Prevent negative duration doses, which can happen if the phone clock is changed
+ Fixes Loop crash when changing time back and cancelling bolus, Loop Issue #2057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants