Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): Overide context variables with input values #424

Closed
wants to merge 1 commit into from

Conversation

celoprd
Copy link

@celoprd celoprd commented Mar 15, 2024

Hi there @ArtiomTr, hope it's alright I open a PR here.

Since July 7th 2023, AWs can now supports github actions inside their codebuild containers see https://aws.amazon.com/fr/about-aws/whats-new/2023/07/aws-codebuild-github-actions/

But they don't support github actions that relies on context object that comes from github. So I cannot use this (amazing) github action.

Inside codebuild container I can access to these variables, since codebuild can listen github events.

So I would like to be able to use your package, with parameters that I gave to it.

The idea is still to fallback on context if you don't provide those variables.

Happy to discuss more about it :)

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
94.24% (-0.03% 🔻)
769/816
🟢 Branches
83.88% (-2.88% 🔻)
281/335
🟢 Functions
92.22% (-0.04% 🔻)
166/180
🟢 Lines
93.73% (-0.02% 🔻)
688/734
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 utils/getPrPatch.ts
25% (-15% 🔻)
100% 0%
25% (-15% 🔻)
🟢
... / formatFailedTestsAnnotations.ts
100%
60% (-20.77% 🔻)
100% 100%
🟢
... / createReport.ts
86.36% (-1.64% 🔻)
37.14% (-25.71% 🔻)
100%
85.71% (-0.65% 🔻)

Test suite run success

165 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from f78d0c0

@ArtiomTr
Copy link
Owner

Hello @celoprd,

Is this thing urgent? Currently, I have very little time to review this PR, maybe I'll be able to check it out this weekend.

@celoprd
Copy link
Author

celoprd commented Mar 15, 2024

Hello @ArtiomTr thanks for you quick answer, not urgent at all :)

@celoprd
Copy link
Author

celoprd commented Mar 15, 2024

Hello again, this pull request is still in draft. It just to get the idea :). If this can be ok, I will add tests and update documentation

@celoprd
Copy link
Author

celoprd commented Mar 18, 2024

Hello @ArtiomTr , do you know when you'll have some time to check it ? not really the code for now, but some discussions abiut the subject

@celoprd
Copy link
Author

celoprd commented Mar 28, 2024

Hello @ArtiomTr do you have news ? :)

@ArtiomTr
Copy link
Owner

Hello @celoprd 👋,

Sorry for late response. I've been thinking about this, and I have few concerns:

  1. First of all, I would like to move all codebuild related options into one. With that, it will be 100% clear why these options are required, and how to use them. Also, this will ensure that if someone wants to configure and run this action under codebuild, they have to specify all of these options.
  2. As stated in section "Limitations of the GitHub action runner in CodeBuild", not only github context is unsupported, but also PR editing is disallowed. I think this action is practically useless without ability to add comments to a PR. However, I believe that with correct token permissions this could be achieved.
  3. I don't have ability to test this. I've never used AWS before, so I am absolutely unfamiliar with it's ecosystem. Can I test this? Do I have to pay to test this? Can tests be automated, so I don't accidentally break things?

Thank you for your patience.

@celoprd celoprd closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants