Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback for getPrPatch.ts #431

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

syossan27
Copy link
Contributor

Hi, @ArtiomTr

This PR fixes #430

This change is a workaround for the limitation on diffs in Pull Requests , which is also mentioned in the ISSUE.

I adopted the method of using octokit.rest.repos.compareCommits to get the differences.
We had a similar situation with the "reviewdog", and I used it as a reference for this implementation.
ref: reviewdog/reviewdog#1697

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
94.04% (-0.23% 🔻)
773/822
🟢 Branches 86.76% 308/355
🟢 Functions 92.27% 167/181
🟢 Lines
93.5% (-0.25% 🔻)
690/738
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 utils/getPrPatch.ts
28.57% (-11.43% 🔻)
100% 0%
28.57% (-11.43% 🔻)

Test suite run success

166 tests passing in 55 suites.

Report generated by 🧪jest coverage report action from 7f750dd

@ArtiomTr ArtiomTr merged commit 2570173 into ArtiomTr:main Sep 9, 2024
6 checks passed
@ArtiomTr
Copy link
Owner

ArtiomTr commented Sep 9, 2024

Hello @syossan27 👋,

Thank you for the contribution.

@all-contributors please add @syossan27 for code

This comment was marked as resolved.

@ArtiomTr
Copy link
Owner

ArtiomTr commented Sep 9, 2024

Your changes are available under v2.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpError: The diff exceeded the maximum number of files (300).
2 participants