日志组件相关优化 #112
Merged
日志组件相关优化 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
优化日志格式，增加链路信息
增加stdout配置判断，如果该配置为true则通过终端输出日志
caller skip
|
您好，感谢你的PR，能否通过微信或者腾讯会议沟通一下，我看好像rotate这块，被改了，之前有一个依赖库lumberjack,用来分段保存日志。这个得一看一下 |
你好，这块没有改哦，文件写日志还是用的lumberjack，应该是你之前把lumberjack封装到lib里了，对应的依赖没有执行go mod tidy 。我改动是把他拿到函数里了
|
|
好的，我测试一下，应该没啥问题 |
|
thx for your pr, pls review v3.2.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Log Example:
{"level":"info","timestamp":"2024-09-09T16:18:12+08:00","caller":"kernel/accessToken.go:370","content":"------------------response content:HTTP/1.1 200 OK\r\nContent-Length: 129\r\nConnection: keep-alive\r\nContent-Type: application/json; encoding=utf-8\r\nDate: Mon, 09 Sep 2024 08:18:12 GMT\r\nLogicret: 40164\r\nRetkey: 11\r\n\r\n{"errcode":40164,"errmsg":"invalid ip 114.218.1.162 ipv6 ::ffff:114.218.1.162, not in whitelist rid: 66deaf44-47fd8d1d-213c2752"}","trace":"1f6161ada79fa84c0955ad9f3b9234d9","span":"660845ac3e69d02c"}