Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamped frontend #139

Merged
merged 1 commit into from
Oct 3, 2023
Merged

revamped frontend #139

merged 1 commit into from
Oct 3, 2023

Conversation

nnisarggada
Copy link
Contributor

@nnisarggada nnisarggada commented Oct 3, 2023

Fixes #138

Fixes #136

Changes Implemented

  • Removed label 'Search'
  • Added placeholder 'Filter Comics'
  • Added space between list and search input
  • Changed bg-color
  • Change bg-color for Contact section
  • Changed icon for 'Source'
  • Removed 'Contact' from nav

Preview

image

image

@ArtskydJ
Copy link
Owner

ArtskydJ commented Oct 3, 2023

I'm not sure I love the light orange background, but I'll see if it grows on me.

@ArtskydJ ArtskydJ merged commit 5786da7 into ArtskydJ:gh-pages Oct 3, 2023
@nnisarggada
Copy link
Contributor Author

Just noticed that most of the changes I've made aren't applied due to the most recent commit reverting them

@ArtskydJ
Copy link
Owner

ArtskydJ commented Oct 3, 2023

This is what I'm seeing on comicsrss.com:

image

@nnisarggada
Copy link
Contributor Author

nnisarggada commented Oct 3, 2023

Yes, from the changes mentioned in the PR, the following have been overwritten by the recent commit (which were added in the PR) -

  • Removed label 'Search'
  • Added placeholder 'Filter Comics'
  • Added space between list and search input
  • Changed icon for 'Source'
  • Removed 'Contact' from nav

The commit after merging this PR overwrites these changes to the old code

@ArtskydJ
Copy link
Owner

ArtskydJ commented Oct 3, 2023

Oh, sorry, I see what happened.

index.html and espanol.html are generated from these files:
https://github.com/ArtskydJ/comicsrss.com/tree/gh-pages/_generator/site-generator/template

I totally missed that you hadn't changed any of those template files. So the CSS changes stuck around, but not the HTML changes.

@nnisarggada
Copy link
Contributor Author

Oh, sorry, I see what happened.

index.html and espanol.html are generated from these files: https://github.com/ArtskydJ/comicsrss.com/tree/gh-pages/_generator/site-generator/template

I totally missed that you hadn't changed any of those template files. So the CSS changes stuck around, but not the HTML changes.

Oh. My bad. Do you want me to change the template files?

ArtskydJ added a commit that referenced this pull request Oct 4, 2023
@ArtskydJ
Copy link
Owner

ArtskydJ commented Oct 4, 2023

I re-added your changes to the templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve frontend Display a better icon for the Source
2 participants