Feature/repacking 2.9 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit primarily moves the entropy-handling code out of ar_chunk_storage and moves it into ar_entropy_storage. In addition to code grouping, this change also made it easier to remove some duplication in the entropy reading/writing code. Previously we had a couple bugs when writing/reading entropy namely: - occasionally we include the chunk offset in the entropy blob - occasionally we forgot to write the chunk offset when writing entropy or an enciphered chunk - occasionally we forgot to write the proofs for a replica.2.9 chunk With this refactoring we've removed a number of redundant code paths - in particular the code paths that were missing one of the steps mentioned above. Hopefully this makes it easier to keep the many different chunk read/write paths in sync going forward. There is at least one more refactoring we can do later: remove the duplication between `record_chunk` and `record_entropy`
Also make sure that unit tests don't block replica.2.9 syncing but e2e tests do.
JamesPiechota
changed the base branch from
master
to
release/N.2.9.0-early-adopter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.