Merge pull request #192 from rebelinux/dev

Fix multiple issues

CHANGELOG.md

@@ -18,6 +18,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Increase Diagrammer.Core minimum requirement
 - Increase AsBuiltReport.Core to v1.4.1
 
+### Fixed
+
+- Fix [#190](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/190)
+- Fix [#191](https://github.com/AsBuiltReport/AsBuiltReport.Microsoft.AD/issues/191)
+- Fix ConvertTo-HashToYN cmdlet not generating an ordereddictionary output
+
 ## [0.9.1] - 2024-11-15
 
 ### Added

Src/Private/SharedUtilsFunctions.ps1

@@ -1036,7 +1036,7 @@ function Get-WinADForestDetail {
     .LINK
 
     #>
-    [OutputType('System.Collections.Specialized.OrderedDictionary')]
+    [OutputType([OrderedDictionary])]
     [CmdletBinding()]
     param(
         [alias('ForestName')][string] $Forest,
@@ -2176,7 +2176,7 @@ function ConvertTo-HashToYN {
     .DESCRIPTION
 
     .NOTES
-        Version:        0.1.0
+        Version:        0.2.0
         Author:         Jonathan Colon
 
     .EXAMPLE
@@ -2185,15 +2185,15 @@ function ConvertTo-HashToYN {
 
     #>
     [CmdletBinding()]
-    [OutputType([Hashtable])]
+    [OutputType([System.Collections.Specialized.OrderedDictionary])]
     Param (
         [Parameter (Position = 0, Mandatory)]
         [AllowEmptyString()]
-        [Hashtable] $TEXT
+        [System.Collections.Specialized.OrderedDictionary] $TEXT
     )
 
     $result = [ordered] @{}
-    foreach ($i in $inObj.GetEnumerator()) {
+    foreach ($i in $TEXT.GetEnumerator()) {
         try {
             $result.add($i.Key, (ConvertTo-TextYN $i.Value))
         } catch {
@@ -2211,7 +2211,7 @@ function Get-ValidDCfromDomain {
         Used by As Built Report to get a valid Domain Controller from Domain.
     .DESCRIPTION
         Function to get a valid DC from a Active Directory Domain string.
-        It use Test-WsMan to test WinRM status from DC.
+        It use Test-WsMan to test WinRM status of the machine.
     .NOTES
         Version:        0.1.0
         Author:         Jonathan Colon