guest: allow unprivileged users to use ping #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the kernel doesn't allow unprivileged users to create ICMP Echo sockets, which can lead to confusing messages like this one: $ ping 1.1.1.1 ping: socktype: SOCK_DGRAM ping: socket: Address family not supported by protocol Most distros adjust "ipv4/ping_group_range" to allow unprivileged users to use "ping" without relying on setuid, so do the same for krun guests. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
requested review from
teohhanhui,
alyssarosenzweig and
asahilina
as code owners
alyssarosenzweig
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the kernel doesn't allow unprivileged users to create ICMP Echo sockets, which can lead to confusing messages like this one:
$ ping 1.1.1.1
ping: socktype: SOCK_DGRAM
ping: socket: Address family not supported by protocol
Most distros adjust "ipv4/ping_group_range" to allow unprivileged users to use "ping" without relying on setuid, so do the same for krun guests.