This repository has been archived by the owner on Jan 11, 2024. It is now read-only.
Better way to get S3 bucket owner #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that we can just ask the bucket who its owner is, so that's much cleaner than passing in the owner as a command-line argument.
bjornswift
reviewed
Jun 22, 2017
| @@ -200,19 +193,30 @@ public void put(String key, byte[] blob) { | |||
| putObject(key, new PutObjectRequest(bucketName, key, new ByteArrayInputStream(blob), new ObjectMetadata())); | |||
| } | |||
|
|
|||
| private synchronized String getBucketOwner() { | |||
There was a problem hiding this comment.
Does is make sense to cache this for the lifetime of the worker? Otherwise you'll be doing two round-trips to S3 for each put, right?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that we can just ask the bucket who its owner is, so that's much cleaner than passing in the owner as a command-line argument.