Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Purchase/Sale Quantity accounted #6

Closed
1 of 2 tasks
Zroyx opened this issue Sep 6, 2023 · 3 comments
Closed
1 of 2 tasks

Wrong Purchase/Sale Quantity accounted #6

Zroyx opened this issue Sep 6, 2023 · 3 comments

Comments

@Zroyx
Copy link

Zroyx commented Sep 6, 2023

Description

This TSM port will account for the wrong quantity/money value.

Realm

Seasonal

Tested with only this addon

  • Yes
  • No

Lua Error

No response

Reproduction Steps

Buy 1 Jaggal Clam Meat for price X, retrieve it from the mailbox. You now got a entry in the database for 1 Jaggal Clam Meat costing X. Now buy a stack of Jaggal Clam Meat for example a stack of 5 costing X each resulting in a total price of Y.

Retrieve it from the mailbox, Now u got a second entry in the database, also for only 1 Jaggal Clam Meat costing now Y instead of X. -> messing up every operation,custom price source using any form of AVGBUY.

Same is true for sale value. Here a screenshot of the example. (the base price was not the same on both but still lower price was stack of 1 higher price stack of 5 resulting is roughly 500% of the "per item" price tag.

Last Good Version

No response

Screenshots

Screenshot of the example, not 100% same base values on the purchases but still lower value for 1 higher value for 5 -> both accounted as quantity 1. Error also confirmed from Xan in the discord.

Screenshot 2023-09-07 005729

@Xan-Asc
Copy link
Contributor

Xan-Asc commented Sep 8, 2023

image

relevant discussion from the version of TSM this is based on.

@Zroyx
Copy link
Author

Zroyx commented Sep 8, 2023

Yea TSM was a Cata thing didnt know there was such a limitation :(

andrew6180 pushed a commit that referenced this issue Sep 20, 2023
@andrew6180
Copy link
Contributor

should be fixed with #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants