Fix some bugs #502
Merged
Fix some bugs #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima-dencep
reviewed
Dec 6, 2023
src/main/java/net/coderbot/iris/mixin/fantastic/MixinParticleEngine.java
Show resolved
Hide resolved
|
tbh I haven’t encountered any problems other than particles, which makes it a bit difficult to test them, but the changes look quite reasonable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getShademixin for Forge's APIThe changes should all be applicable to 1.19.2 as well. Some refactoring might be needed for 1.18.2 and older.
Note: I don't play with shaders, so please playtest the changes to make sure nothing has regressed from the previous release.