Port to Latest Template Dev Env #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(template is latest from this commit on main [c19ab24](CleanroomMC/TemplateDevEnv@c19ab24)) Important: - Migrated mcmod.info and other related options to "gradle.properties", these should be the same unless stated. - Migrated dependencies to "dependencies.gradle" (under "../gradle/scripts/") - "Fixed" not being able to run the dev client ("runClient" gradle task), there is a big note on "dependencies.gradle" as to how I partially "fixed" (hence the quotes) it. - Renamed "vintagium.mixin.json" to "mixin.vintagium.json" (and propagate changes to SodiumMixinTweaker::getMixinConfigs) to fit style enforced by gradle.build by default Other minor changes: - Removed support for version 1.13 as the template is too embedded into Cleanroom (1.12.2 only so far) - Upgraded Gradle to 8.12 - Upgraded foojay-resolver-convention to 0.8.0 - Upgrade to minimum Mixin version of 0.8.5 - In "mixin.vintagium.json" file I added the follow entry-> "target": "@env(DEFAULT)" This might not be wanted but the template had it so I might as well add it (no idea what it does)
|
This definitely needs a review by the way, didn't do things 100% correct as I'm not that experienced in the field |
|
Seems like Vintagium is hard depending both on LolASM and FermiumASM thats why runClient was failing before bdb5d0c#diff-57c8077621420d8708b8b41ff49da0f2688ba9f380fd4a9b01d04b34ba235220 Thats pretty goofy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(template is latest from this commit on main c19ab24)
(most, if not all, changes are made to restructure to the latest Cleanroom dev template as stated, didn't really change much myself!)
Important:
Other minor changes:
This might not be wanted but the template had it so I might as well add it (no idea what it does).
Why?: