Fix for Issue #455 (Adding support for UTF-8 slug)

[darron1217]

Fix for Issue #455 (Adding support for UTF-8 slug)

[nWidart]

Looks like the tests fail b/c the file isn't required in the tests.

I'm also thinking maybe this is something that should be sent to laravel instead?

[darron1217]

@nWidart
Laravel rejected similar PR... :(
They recommend implementing utf8 slug method by ourselves

laravel/framework#6867

[nWidart]

Hello,

Could you add a test for this method?

[nWidart]

Thanks, maybe it's also worth pulling in all the tests str_slug() has on its own?

[darron1217]

@nWidart Okay

Is this code below is what you said?

https://github.com/laravel/framework/blob/9cf82b9fa7edf5a66a78e69c91abb685f13ed4a1/tests/Support/SupportStrTest.php#L138-L145

[nWidart]

That looks like it indeed. Since we're replicating that method just to make sure the 'base' cases work, and keep working in the future 😄

Maybe have one test with all the new ones, plus your new one added.

[darron1217]

@nWidart I've done it :)

[nWidart]

Thanks! 👍