Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix route:cache and config:cache issue #554

Merged
merged 1 commit into from
Jul 9, 2018
Merged

fix route:cache and config:cache issue #554

merged 1 commit into from
Jul 9, 2018

Conversation

huydang284
Copy link
Contributor

@huydang284 huydang284 commented Jul 2, 2018

Hi @nWidart,

This is my pull request in Asgard version 3.
Pull request in version 2: #544

Please merge.

Thank you,
Huy Dang

@mikemand
Copy link
Contributor

mikemand commented Jul 2, 2018

For curiosity's sake, why are route bindings being done in the service provider? Does route:cache prevent them from working in the route files?

@nWidart
Copy link
Member

nWidart commented Jul 2, 2018

@mikemand I had the same question too :D . It actually makes sense, once cached, laravel won't open those route files anymore, and thus we would lose the binding, causing 404's etc.

Thanks @huydang284 for sending on 3.0, will check it out soon.

@nWidart nWidart merged commit 53e8692 into AsgardCms:3.0 Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants