Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adopt Resolve-ManifestObject for installation #237

Merged
merged 16 commits into from
Dec 8, 2021
Merged

Conversation

Ash258
Copy link
Owner

@Ash258 Ash258 commented Dec 4, 2021

Ability to install YML typed manifests 🎉🎉

Including ability to installed archived versions without regeneration

#2, #140, #61
Take 2 of #229 without experiments and syncs

YAML install:

image

List:

image

Archived:

image
image

@Ash258 Ash258 added the enhancement New feature or request label Dec 4, 2021
@Ash258 Ash258 added this to the 0.6.5 milestone Dec 4, 2021
@Ash258 Ash258 self-assigned this Dec 4, 2021
@Ash258 Ash258 added the debt Code quality issues label Dec 4, 2021
@Ash258

This comment has been minimized.

@Ash258

This comment has been minimized.

@Ash258
Copy link
Owner Author

Ash258 commented Dec 4, 2021

Verification run 1 start //.post: rm libexec/scoop-install.ps1; rename-item libexec/scoop-install-new.ps1 scoop-install.ps1

Investigate delayed runner start.

@Ash258 Ash258 marked this pull request as ready for review December 4, 2021 19:20
@Ash258
Copy link
Owner Author

Ash258 commented Dec 4, 2021

Installation is working fine. Update needs to be reverified.

@Ash258 Ash258 marked this pull request as draft December 4, 2021 20:02
@Ash258
Copy link
Owner Author

Ash258 commented Dec 8, 2021

image

image

image

image

@Ash258
Copy link
Owner Author

Ash258 commented Dec 8, 2021

Update seems fine even with dependencies

image

@Ash258 Ash258 marked this pull request as ready for review December 8, 2021 18:15
@Ash258
Copy link
Owner Author

Ash258 commented Dec 8, 2021

image

@Ash258
Copy link
Owner Author

Ash258 commented Dec 8, 2021

image

@Ash258 Ash258 merged commit b001941 into NEW Dec 8, 2021
@Ash258 Ash258 deleted the installResolve branch December 8, 2021 19:11
howyay pushed a commit to howyay/Scoop-Core that referenced this pull request Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant