Remove unused imports from scoop prefix command #261
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
scoop prefix
takes almost half a second to complete:Considering how often this command is usually used, this drastically reduced the whole system performance. For example, oh-my-posh's installation doc page has this script:
"$(scoop prefix oh-my-posh)\themes\jandedobbeleer.omp.json"
.I noticed 4 of the 6 import libraries are not currently used. Removing them reduces the time to 120ms:
Although this is still way too long in my opinion, it's much better. I hope you guys can keep going with improving this command.