The FlowPage is constantly being recomposed

[lazzzis]

1. Environment

Latest build

2. Describe the bug

Add this log Log.i("RLog", "ArticleItem: recomposition ${articleWithFeed.article.title}") to ArticleItems.kt

ReadYou/app/src/main/java/me/ash/reader/ui/page/home/flow/ArticleItem.kt

Lines 78 to 84 in 4c7bea9

	@Composable
	fun ArticleItem(
	articleWithFeed: ArticleWithFeed,
	onClick: (ArticleWithFeed) -> Unit = {},
	) {
	val articleListFeedIcon = LocalFlowArticleListFeedIcon.current
	val articleListFeedName = LocalFlowArticleListFeedName.current

Build, launch and navigate to FlowPage.

In the logcat, I am seeing the ArticleItem is endlessly being recomposed.

---

I am sure this bug is introduced in commit #594, since this issue is not observed on the build based on its previous commit.

The debugger says these two values are changed during every recomposition

ReadYou/app/src/main/java/me/ash/reader/ui/page/home/flow/FlowPage.kt

Lines 102 to 112 in 4c7bea9

	val onSwipeEndToStart = when (swipeToStartAction) {
	SwipeStartActionPreference.None -> null
	SwipeStartActionPreference.ToggleRead -> onToggleRead.value
	SwipeStartActionPreference.ToggleStarred -> onToggleStarred.value
	}
	val onSwipeStartToEnd = when (swipeToEndAction) {
	SwipeEndActionPreference.None -> null
	SwipeEndActionPreference.ToggleRead -> onToggleRead.value
	SwipeEndActionPreference.ToggleStarred -> onToggleStarred.value
	}

If I hardcoded these two variables to null, this issue is not observed.

I don't understand why these two values are keeping changing. But I guess they are the root causes which make the flow page a little sluggish.

[JunkFood02]

Thanks!