feat(ui): swipe to star/unstar, swipe to unread #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR forks the implementation of MD3 related issue: https://issuetracker.google.com/issues/324170119 |
|
I can confirm the most recent commit fixed article swipe velocity bug. Great work! |
|
I just found a visual bug related to the swipe gesture. The background icons and text for smaller article items look bad. 97087722-1a62-4deb-b087-dad2e88a7983.mp4 |
Closed
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also migrate from MD2
SwipeDismissto MD3SwipeToDismissBox, should fix some visual glitches like #506cc @nvllz
Close #194
Close #586