Fix rapid dismiss bug in ArticleItem #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @nvllz This PR seems to have some conflicts with the latest main branch. |
|
Roger, will work on it soon. Edit: JunkFood02 fixed it in a much better way, thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the swipeToDismiss Compose bug, which causes energetic swipes to dismiss feed items. Until it's fixed, we have to use a walkaround. Everything works fine now, but we desperately need some listing animation, because this kind of raw item list reload looks a bit bad.
I based this PR on #502 (thanks!) with updated dependencies, so this will have to wait for the bump to be merged, because it doesn't apply to current build.gradle settings.
b7644d56-537e-4380-b3e5-3449acfb0e54.mp4
Thanks for keeping this project up!