Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump up dependencies, compile sdk, and gradle version #502

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

JunkFood02
Copy link
Collaborator

What did this pull request do?

  • Migrate to Compose BOM, and update Compose dependencies to Compose BOM 2023.10.01
  • Update Compose compiler to 1.5.7 (requires Kotlin 1.9.21)
  • Update Kotlin to 1.9.21
  • Update a bunch of dependencies (hilt, coil, okhttp, room, accompanist, lifecycle)
  • Update Android Gradle Plugin to 8.2.1, and Gradle to 8.0
  • Update compileSdk to 34 (not tragetSdk)
  • Changes are made to source to pass the lint check

Note

Potential breaking changes and bugs may probably occur during usage. Please test these changes carefully before merging this PR, or consider publishing an alpha release.

@mbestavros
Copy link
Collaborator

@JunkFood02 I'm going to cut 0.9.9 without this change, and then we can cut 0.9.10 with it included once you're satisfied it's stable (along with any other improvements that come along).

@JunkFood02 JunkFood02 marked this pull request as draft January 9, 2024 19:53
@mbestavros
Copy link
Collaborator

@JunkFood02 - when you have a moment, would you be willing to rebase this? We've gotten a lot of fixes merged recently, and I'd say Read You is in a fairly stable state at present. Might be a good time to evaluate a test APK for any obvious bugs that would be caused by the dependency bumps.

@Ashinch
Copy link
Owner

Ashinch commented Jan 18, 2024

@mbestavros The highlight of version 0.9.12 is the integration of the GoogleReader API. This pull request might need to be delayed a bit and may require merging after the release of version 0.9.12. Once this pull request is merged, significant refactoring of the user interface code will be necessary to ensure proper functionality.

@JunkFood02
Copy link
Collaborator Author

JunkFood02 commented Jan 18, 2024

user interface code will be necessary to ensure proper functionality

I believe that we can focus on those experimental APIs first, then gradually refactor the rest part of the code, since most Compose API are already stable. The main goal of this PR is to resolve the performance issues which had been addressed in recent Compose updates.

@JunkFood02 JunkFood02 marked this pull request as ready for review January 18, 2024 10:03
@nvllz nvllz mentioned this pull request Jan 19, 2024
@Ashinch Ashinch added this to the 0.9.13 milestone Jan 20, 2024
@JunkFood02 JunkFood02 linked an issue Jan 23, 2024 that may be closed by this pull request
@JunkFood02 JunkFood02 changed the base branch from main to dev January 30, 2024 16:12
@JunkFood02 JunkFood02 merged commit 178c771 into Ashinch:dev Jan 30, 2024
1 check passed
Ashinch pushed a commit that referenced this pull request Feb 6, 2024
)

* build(deps): bump up dependencies, compile sdk, and gradle version

* build(deps): remove redundant safe-args plugin

* build(deps): update Compose BOM to `2024.01.00` & compiler to `1.5.8`
Ashinch added a commit that referenced this pull request Feb 6, 2024
* build(deps): bump up dependencies, compile sdk, and gradle version (#502)

* build(deps): bump up dependencies, compile sdk, and gradle version

* build(deps): remove redundant safe-args plugin

* build(deps): update Compose BOM to `2024.01.00` & compiler to `1.5.8`

* fix(i18n): configuration loss when switching locale (#541)

* fix(i18n): configuration loss when switching locale

* feat(locale): enable auto-localeconfig

* feat(i18n): add languages to in-app language picker (#571)

* feat(i18n): add languages to in-app language picker

* fix(i18n): locale system settings not working for Android 13

* feat(i18n): show selected language at settings page

* fix(ci): ignore ExtraTranslation for linter

* feat(i18n): add fallback in in-app language picker for A13+

* chore: clean up

* fix(ui): ProgressIndicator crashes in m3 1.1.2

* fix(ui): NavigationBarItem color

* feat(ui): grey out read articles even if starred (#547)

* refactor(ui): improve add account dialog

* fix(ui): accessing listState on io thread causes app to crash

* fix(ui): NavigationBar text color

* feat(ui): show full screen image viewer when clicking on images (#578)

* feat(ui): add crash report activity to handle uncaught exceptions (#576)

* feat(ui): swipe up and down to switch between articles (WIP)

* feat(ui): update animation

* docs(ui): add comments on pull to load implementation

* feat(ui): move the indicator to another file

* build: revert changes

* feat(ui): make the transition directions match the content changes

---------

Co-authored-by: MauroGuida <57829432+MauroGuida@users.noreply.github.com>
Co-authored-by: Ash <Glaxyinfinite@outlook.com>
Co-authored-by: Ash <Ashinch@outlook.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling is broken with "Remove animations" enabled
3 participants