Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): add languages to in-app language picker #571

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

JunkFood02
Copy link
Collaborator

@JunkFood02 JunkFood02 commented Jan 30, 2024

What does this PR do?

  • Add all languages whose translation progress exceeds 50% in Hosted Weblate to the in-app language picker
  • Modify the display order according to their language codes
  • A little bit modifications to avoid possible confusion ^^;

Expected behaviors:

  • Android 12 and below, in-app language picker works as expected
  • Android 13 and above, changes made to app language from system settings or in-app language picker should align with the other one.

@JunkFood02 JunkFood02 marked this pull request as draft January 30, 2024 19:13
@JunkFood02 JunkFood02 marked this pull request as ready for review January 30, 2024 20:08
@JunkFood02 JunkFood02 merged commit 66b1d51 into Ashinch:dev Jan 31, 2024
1 check failed
Ashinch pushed a commit that referenced this pull request Feb 6, 2024
* feat(i18n): add languages to in-app language picker

* fix(i18n): locale system settings not working for Android 13

* feat(i18n): show selected language at settings page

* fix(ci): ignore ExtraTranslation for linter

* feat(i18n): add fallback in in-app language picker for A13+

* chore: clean up
Ashinch added a commit that referenced this pull request Feb 6, 2024
* build(deps): bump up dependencies, compile sdk, and gradle version (#502)

* build(deps): bump up dependencies, compile sdk, and gradle version

* build(deps): remove redundant safe-args plugin

* build(deps): update Compose BOM to `2024.01.00` & compiler to `1.5.8`

* fix(i18n): configuration loss when switching locale (#541)

* fix(i18n): configuration loss when switching locale

* feat(locale): enable auto-localeconfig

* feat(i18n): add languages to in-app language picker (#571)

* feat(i18n): add languages to in-app language picker

* fix(i18n): locale system settings not working for Android 13

* feat(i18n): show selected language at settings page

* fix(ci): ignore ExtraTranslation for linter

* feat(i18n): add fallback in in-app language picker for A13+

* chore: clean up

* fix(ui): ProgressIndicator crashes in m3 1.1.2

* fix(ui): NavigationBarItem color

* feat(ui): grey out read articles even if starred (#547)

* refactor(ui): improve add account dialog

* fix(ui): accessing listState on io thread causes app to crash

* fix(ui): NavigationBar text color

* feat(ui): show full screen image viewer when clicking on images (#578)

* feat(ui): add crash report activity to handle uncaught exceptions (#576)

* feat(ui): swipe up and down to switch between articles (WIP)

* feat(ui): update animation

* docs(ui): add comments on pull to load implementation

* feat(ui): move the indicator to another file

* build: revert changes

* feat(ui): make the transition directions match the content changes

---------

Co-authored-by: MauroGuida <57829432+MauroGuida@users.noreply.github.com>
Co-authored-by: Ash <Glaxyinfinite@outlook.com>
Co-authored-by: Ash <Ashinch@outlook.it>
@Ashinch Ashinch added this to the 0.9.13 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants