-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Some new features and fixes #481
Conversation
I have also make some changes for
|
Thanks for your work, I will take some time to review and merge them. For
another way of switching articles, I intend to provide multiple options
later, but not within the scope of this PR.
Best regards,
Ash
… I have also make some changes for
- Feeds sort support
- export starred items to a single json file
- support swipe guestures for switching article (based on #468
<#468> , I dropped my previous
implements(on my dev branch) after I noticed there are a pr already here
which is a better approach), swipe left and right for article switching and
pull down for fetch full contents
- indicator support on the article page
- auto scroll to the new article position when you swipe to another
article
- backward swipe support
—
Reply to this email directly, view it on GitHub
<#481 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJHDDN4Y6W4XKEB6GZPNZ3YAXBVRAVCNFSM6AAAAAA6D6VN5WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGI4DGOJTGM>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Okay, please let me know if you think any code is not mature to merge or foolish, I'll be very happy to improve my kotlin skills.
Yes, I hold the same opinion, I would wait for the #468 to be merged and do some work then. |
@aeghn It's awesome that you're contributing so many meaningful changes to the app! These do seem like they could be breaking changes, or otherwise need further testing - @Ashinch if you're considering taking these features on, maybe consider cutting the |
@mbestavros You're right, #481 and #468 will not be merged until after 0.9.9 is released. |
Great work! I like the way horizontal swiping works, and the ability to swipe back to previous articles makes it even better. But I also found the gesture too sensitive, I hope there's a way to make it less prone to undesirable swipes. |
I realized this PR is a little big, so I'm trying split it into some little PRs. |
The pull request has already been split and merged, so it will be closed. If there are any remaining features, you can submit them separately. |
Remember Feeds Postionremeber feed pages position #519only swipe to remove artile with unread filteronly swipe to remove artile with unread filter #520readyou.mp4