Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Some new features and fixes #481

Closed
wants to merge 7 commits into from
Closed

WIP: Some new features and fixes #481

wants to merge 7 commits into from

Conversation

aeghn
Copy link
Contributor

@aeghn aeghn commented Oct 17, 2023

readyou.mp4

@aeghn aeghn changed the title Remember Feeds Postion and ignore queryRssIcon exception Some new features and fixes Oct 23, 2023
@aeghn
Copy link
Contributor Author

aeghn commented Oct 23, 2023

I have also make some changes for

  • Feeds sort support
  • export starred items to a single json file
  • support swipe guestures for switching article (based on [RFC] Swipe ReadingPage #468 , I dropped my previous implements(on my dev branch) after I noticed there are a pr already here which is a better approach), swipe left and right for article switching and pull down for fetch full contents
  • indicator support on the article page
  • auto scroll to the new article position when you swipe to another article
  • backward swipe support

@Ashinch
Copy link
Owner

Ashinch commented Oct 23, 2023 via email

@aeghn
Copy link
Contributor Author

aeghn commented Oct 23, 2023

Thanks for your work, I will take some time to review and merge them.

Okay, please let me know if you think any code is not mature to merge or foolish, I'll be very happy to improve my kotlin skills.

For another way of switching articles, I intend to provide multiple options later, but not within the scope of this PR.

Yes, I hold the same opinion, I would wait for the #468 to be merged and do some work then.

@boun boun mentioned this pull request Oct 24, 2023
@mbestavros
Copy link
Collaborator

mbestavros commented Oct 25, 2023

@aeghn It's awesome that you're contributing so many meaningful changes to the app!

These do seem like they could be breaking changes, or otherwise need further testing - @Ashinch if you're considering taking these features on, maybe consider cutting the 0.9.9 release before merging this and #468? Then, more dedicated users can test these new features for a later 0.9.10 release.

@Ashinch
Copy link
Owner

Ashinch commented Oct 26, 2023

These do seem like they could be breaking changes, or otherwise need further testing - @Ashinch if you're considering taking these features on, maybe consider cutting the 0.9.9 release before merging this and #468? Then, more dedicated users can test these new features for a later 0.9.10 release.

@mbestavros You're right, #481 and #468 will not be merged until after 0.9.9 is released.

@nvllz
Copy link
Contributor

nvllz commented Oct 30, 2023

Great work! I like the way horizontal swiping works, and the ability to swipe back to previous articles makes it even better. But I also found the gesture too sensitive, I hope there's a way to make it less prone to undesirable swipes.

@aeghn
Copy link
Contributor Author

aeghn commented Jan 12, 2024

I realized this PR is a little big, so I'm trying split it into some little PRs.

@aeghn aeghn changed the title Some new features and fixes WIP: Some new features and fixes Jan 12, 2024
@Ashinch
Copy link
Owner

Ashinch commented Jan 19, 2024

The pull request has already been split and merged, so it will be closed. If there are any remaining features, you can submit them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants