fix(ui): fix performance & data loading issues with sticky headers disabled #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sabled; Disable sticky headers by default
|
@Ashinch @JunkFood02 Any reason this can't be merged? |
The performance regression is not quite noticable with limited items (50 items per page currently). The issue of current implementation is that the app won't load new pages correctly because of the usage of |
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR:
Related issues:
https://issuetracker.google.com/u/1/issues/193785330
https://stackoverflow.com/questions/67649953/sticky-headers-with-paging-library-in-jetpack-compose