feat(greader): sort categories alphabetically during sync #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #535 |
JunkFood02
reviewed
May 30, 2024
| @@ -228,7 +228,7 @@ class GoogleReaderRssService @Inject constructor( | |||
|
|
|||
| // 2. Fetch folder and subscription list | |||
| googleReaderAPI.getSubscriptionList() | |||
| .subscriptions.groupBy { it.categories?.first() } | |||
| .subscriptions.sortedBy { it.categories?.sortedBy { it.label }?.first()?.label }.groupBy { it.categories?.first() } | |||
There was a problem hiding this comment.
This seems a bit complicated for me. Though I don't use Google Reader, I guess we only need the first (and the only) element in categories here. And we can sort the map after we group the list by the category.
| @@ -228,7 +228,7 @@ class GoogleReaderRssService @Inject constructor( | |||
|
|
|||
| // 2. Fetch folder and subscription list | |||
| googleReaderAPI.getSubscriptionList() | |||
| .subscriptions.groupBy { it.categories?.first() } | |||
| .subscriptions.sortedBy { it.categories?.sortedBy { it.label }?.first()?.label }.groupBy { it.categories?.first() } | |||
There was a problem hiding this comment.
Suggested change
| .subscriptions.sortedBy { it.categories?.sortedBy { it.label }?.first()?.label }.groupBy { it.categories?.first() } | |
| .subscriptions.groupBy { it.categories?.first() } | |
| .toSortedMap { c1, c2 -> c1?.label.toString().compareTo(c2?.label.toString()) } |
There was a problem hiding this comment.
@JunkFood02 Yeah, I like this better. Tested it and it works well. Added! Thanks for the suggestion!
Signed-off-by: Mark Bestavros <markbest@bu.edu>
mbestavros
force-pushed
the
sort-categories-greader
branch
from
2205b6e
to
57fd946
Compare
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a pet peeve of mine when using the Greader API: categories/folders aren't sorted alphabetically when in the Feeds view. The way the app works today, categories are arranged by whichever category has the feed with the lowest lexicographical order, which is very unintuitive.
As an example, let's say I have the following categories and feeds:
Under the current code, these categories get ordered as:
because
A banana a day keeps the doctor awayis lexicographically beforeFruits of the Day.While it's true that we should probably implement some way to allow the user to manually reorder feeds, this is a quick fix that requires little effort. Plus, even if we did have manual category sorting, it's still nice to present a sensible lexicographic default.
Tagging @Ashinch and @JunkFood02 for review.