Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent casing prevents this addin from being audited #20

Open
Jericho opened this issue Jun 2, 2018 · 0 comments
Open

Inconsistent casing prevents this addin from being audited #20

Jericho opened this issue Jun 2, 2018 · 0 comments

Comments

@Jericho
Copy link

Jericho commented Jun 2, 2018

The .sln file contains the fillowing reference:

Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Cake.Stylecop", "Cake.Stylecop\Cake.Stylecop.csproj", "{533D0E04-D306-4427-BA0E-29FAC90A6867}"
EndProject

(notice the lower case 'c' in Cake.Stylecop.csproj) but the csproj committed in this github repo is actually called Cake.StyleCop.csproj (with upper case 'c'). Visual Studio is not case sensitive therefore this is not a problem but if you parse the content of this file and use it to make requests to the github API (which is case-sensitive), proper casing becomes really important.

It so happens that the cake-contrib organization runs an automated process twice a day to determine if addins follow best practices, reference latest version of DLLs, etc and currently the audit tool fails to parse the project due the discrepancy in casing.

I recommend the casing be fixed in order for the project to be successfully audited.

Jericho added a commit to Jericho/Cake.StyleCop that referenced this issue Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant