Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables OPTIONS HTTP method for preflight requests in the FE #2

Merged
merged 18 commits into from
Aug 29, 2023

Conversation

radzki
Copy link

@radzki radzki commented Aug 28, 2023

This PR should fix the error we have when trying to stream (PUT) data into our signed URLS, using the emulator locally. Currently, it doesn't support OPTIONS, nor it returns a permissive access-control-allow-origin header.

Copy link

@asimov-layton asimov-layton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Should we consider a contribution to the upstream project?

@radzki
Copy link
Author

radzki commented Aug 29, 2023

Nice! Should we consider a contribution to the upstream project?

There is already a PR (which is basically 98% of this code) opened since 2022... I don't think they are prioritizing it too much, hahahaha

@radzki radzki merged commit 039f5c8 into main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants