-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell completions #493
Shell completions #493
Conversation
Note: The completion was written by isaec. I wrote the PKGBUILD change. Co-authored-by: isaec <isaec@users.noreply.github.com>
@Askannz Hi! Any update on getting this merged? |
I appreciate you using the fish completions I wrote - fish has added Optimus completions on their end so adding those is no longer needed, they ship with fish shell. |
@isaec I don't know how it is for fish, but zsh encourages projects to ship their own completions rather than having completions bundled with zsh, as that allows keeping things up-to-date easier, and ensures the completions matches the installed version. I can certainly remove the fish completions from the PR, but are you sure? |
I don't know what fish recommends, sorry - just wanted to inform you. |
|
I'll close #437 too, thanks |
@es20490446e these are zsh completions, not fish. So that doesn't make any sense to me. Why exactly did you close this PR? EDIT: Ah, seems I included fish completions too for some reason? Strange since I don't use fish. I cannot comment on if fish completions are useful or not. |
Then:
And I will merge 🫗 By the way, from now on, I will be merging any correct pull request in a couple of days max. |
This implements issue #478 and issue #437.
Notes: