Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell completions #493

Closed
wants to merge 2 commits into from
Closed

Conversation

VorpalBlade
Copy link
Contributor

This implements issue #478 and issue #437.

Notes:

  • I have not tested the fish completion myself, but simply installed it where other packages install their fish completions on Arch Linux.
  • The zsh completion has changed slightly from the one in the issue, as I have learned more about how to properly write zsh completion files since then.
  • The PKGBUILD is updated in this commit, but the changes will need to be synced to the AUR repo PKGBUILD to update that one as well.

VorpalBlade and others added 2 commits May 13, 2022 13:52
Note: The completion was written by isaec. I wrote the PKGBUILD change.

Co-authored-by: isaec <isaec@users.noreply.github.com>
@VorpalBlade VorpalBlade changed the title Feature/completions Shell completions May 22, 2022
@VorpalBlade
Copy link
Contributor Author

@Askannz Hi! Any update on getting this merged?

@a-viv-a
Copy link

a-viv-a commented Jun 20, 2022

I appreciate you using the fish completions I wrote - fish has added Optimus completions on their end so adding those is no longer needed, they ship with fish shell.

@VorpalBlade
Copy link
Contributor Author

@isaec I don't know how it is for fish, but zsh encourages projects to ship their own completions rather than having completions bundled with zsh, as that allows keeping things up-to-date easier, and ensures the completions matches the installed version.

I can certainly remove the fish completions from the PR, but are you sure?

@a-viv-a
Copy link

a-viv-a commented Jun 20, 2022

I don't know what fish recommends, sorry - just wanted to inform you.

@es20490446e
Copy link
Collaborator

  1. Have a look if the completions provided by fish itself are sufficient.
  2. Edit this pull request accordingly.
  3. Reopen.

@a-viv-a
Copy link

a-viv-a commented Mar 27, 2024

I'll close #437 too, thanks

@VorpalBlade
Copy link
Contributor Author

VorpalBlade commented Mar 27, 2024

  1. Have a look if the completions provided by fish itself are sufficient.
  2. Edit this pull request accordingly.
  3. Reopen.

@es20490446e these are zsh completions, not fish. So that doesn't make any sense to me. Why exactly did you close this PR?

EDIT: Ah, seems I included fish completions too for some reason? Strange since I don't use fish. I cannot comment on if fish completions are useful or not.

@es20490446e
Copy link
Collaborator

es20490446e commented Mar 27, 2024

Then:

  1. Remove the fish completions.
  2. Reopen.

And I will merge 🫗

By the way, from now on, I will be merging any correct pull request in a couple of days max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants